[Bug 778434] applemedia: race condition in videotexturecache.m

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778434

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345418|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 345418:
 --> (https://bugzilla.gnome.org/review?bug=778434&attachment=345418)

::: sys/applemedia/iosglmemory.c
@@ +43,3 @@
   GstIOSGLMemory *mem = (GstIOSGLMemory *) gl_mem;

+  CFRelease (mem->texture);

This can still be called from a random thread... basically whenever the memory
loses its last reference. And the destroy notify is AFAIU called from exactly
the same place, it would be called in the
GST_GL_BASE_MEMORY_ALLOCATOR_CLASS(parent_class)->destroy() a couple of lines
below.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.