[Bug 778437] gsticydemux: reset tags on empty StreamTitle value

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778437

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net
 Attachment #345414|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 345414
  --> https://bugzilla.gnome.org/attachment.cgi?id=345414
gsticydemux: reset tags on empty value

Thansk for the patch, but this does not compile (you might also want to just
use a boolean for the tags_found):

  CC       libgsticydemux_la-gsticydemux.lo
gsticydemux.c: In function ‘gst_icydemux_parse_and_send_tags’:
gsticydemux.c:343:7: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
       char *title = gst_icydemux_unicodify (strings[i] + 13);
       ^~~~
gsticydemux.c:352:7: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
       char *url = gst_icydemux_unicodify (strings[i] + 11);
       ^~~~
ggsticydemux.c: In function ‘gst_icydemux_chain’:
gsticydemux.c:367:6: error: ‘tags_found’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
   if (tags_found)
      ^
gsticydemux.c:325:18: note: ‘tags_found’ was declared here
   int length, i, tags_found;
                  ^~~~~~~~~~

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.