[Bug 778432] Crash on state chang to NULL during mp3_type_find_at_offset

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778432

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345408|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 345408:
 --> (https://bugzilla.gnome.org/review?bug=778432&attachment=345408)

::: gst/typefind/gsttypefindfunctions.c
@@ +1507,3 @@
       }
       g_assert (found <= GST_MP3_TYPEFIND_TRY_HEADERS);
+      if (found > 0 && head_data == NULL &&

As you say, found is a guint... so checking for > 0 will always be TRUE

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.