[Bug 778453] GstV4l2VideoDec: leaks pads opening the decoder device

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778453

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345458|none                        |needs-work
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 345458:
 --> (https://bugzilla.gnome.org/review?bug=778453&attachment=345458)

The comment is miss-leading, since it does not fix a leak, it just prevent the
refcount from increasing. I think instead you should drop  gst_caps_ref (caps);
in the return statement of those getters. As you should have seen in
gstv4l2object.c, those are leaked on purpose to avoid the overhead of
re-building the base template caps. Note that I notice those function are not
thread safe, might be worth fixing.

On other notes use style "v4l2videodec:" for comment prefix. You should use
valgrind or internal leak tracer to validate your patches.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.