[Bug 763326] gst-launch of 8-channel deinterleave pipeline stalls

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763326

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345712|none                        |needs-work
             status|                            |

--- Comment #28 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 345712:
 --> (https://bugzilla.gnome.org/review?bug=763326&attachment=345712)

::: libs/gst/base/gstbasetransform.c
@@ +672,3 @@
     gst_caps_unref (peerfilter);

+  if (peercaps && !gst_caps_is_empty (peercaps)) {

This is not equivalent though. If the caps are empty, now we would work with
the template caps. Before we would work with the empty caps and error out.

I think you want to add a "if (gst_caps_is_empty(peercaps)) goto done;" above
instead

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.