[Bug 778702] videotimecode: Init from GDateTime

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778702

--- Comment #4 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Review of attachment 345950:
 --> (https://bugzilla.gnome.org/review?bug=778702&attachment=345950)

Looks good generally, but don't forget to add some unit tests as well!

::: gst-libs/gst/video/gstvideotimecode.c
@@ +226,3 @@
+      g_date_time_get_second (dt), frames, field_count);
+
+  gst_video_time_code_add_frames (tc, frames);

Why do you init using the frames and then re-add the frames?

You should also add a check in case the timecode is invalid, e.g. 01:02:03;00

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.