[Bug 778702] videotimecode: Init from GDateTime

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778702

Vivia Nikolaidou <vivia at ahiru.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #345974|none                        |needs-work
             status|                            |

--- Comment #5 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Review of attachment 345974:
 --> (https://bugzilla.gnome.org/review?bug=778702&attachment=345974)

Looks good, I think it can be committed when a couple of unit tests are added
to cover the new functionality. Thanks! :)

::: gst-libs/gst/video/gstvideotimecode.c
@@ +224,3 @@
+  gst_video_time_code_init (tc, fps_n, fps_d, jam, flags,
+      0, 0, 0, 0, field_count);
+  gst_video_time_code_add_frames (tc, frames);

Yes, that should work better than the previous one :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.