[Bug 778703] timecodestamper: Timecode from current system time

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778703

--- Comment #4 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Review of attachment 345953:
 --> (https://bugzilla.gnome.org/review?bug=778703&attachment=345953)

::: gst/timecode/gsttimecodestamper.c
@@ +142,3 @@
+      g_param_spec_boxed ("first-timecode",
+          "Timecode at the first frame",
+          "If unset, the timecode will start at 0",

You should write a description (and check that it works) about which property
overrides which. For instance, it would make sense for one of FIRST_TIMECODE
and FIRST_NOW to override the other, and for both to override CLOCK_SOURCE.
Maybe you should add a "mode" option that would point to one of {running-time,
from-clock, from-date-time, now}, but that would require the user to set two
properties. Which solution do you think looks cleaner?

@@ +477,3 @@
     }
+  } else if (timecodestamper->source_clock == NULL &&
+      timecodestamper->first_tc == NULL) {

Add some sanity checks (especially in this function) that the timecodestamper
won't act up in case e.g. both source-clock and first-timecode are given.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.