[Bug 775490] vaapi: encode: jpeg should release configuration after each frame (multi file support)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775490

--- Comment #28 from Stirling Westrup <swestrup at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #26)
> (In reply to Hyunjun Ko from comment #25)
> > (In reply to Víctor Manuel Jáquez Leal from comment #24)
> > > Summarizing, right now in master is possible to encode multiple images of
> > > the same caps. But, not for different ones, is that case still the matter of
> > > this bug? Or do we close it now?
> > 
> > In Stirling's patch, the following is worth merge, I guess.
> > Looks it has potential bugs without this, even though it doesn't affect at
> > the moment.
> > 
> > encoder->num_codedbuf_queued--;
> 
> That cannot be merged because that is not the intention of that variable
> AFAIK. It is a global counter of processed buffers, not the size of the
> queue.
> 

It certainly wasn't clear from context what that counter was for but there is
an explicit test of it that prevents caps renegotiation when it is non-zero, so
I assumed it was a count of buffers in progress.

Since defeating that test had no negative consequences on functionality and
allowed for mid-stream caps renegotiation, I recommend the removal of the test
of encoder->num_codedbuf_queued being non-zero.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.