[Bug 736213] h264parse: process NAL AU DELIMITER

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=736213

--- Comment #18 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #17)
> Review of attachment 346038 [details] [review]:
> 
> Also, since AU delimiter is optional, there should be a property, imo.

Some people want that it should be by default. I have no idea of this thing. 
Hope that listen to opinion of someone else. :)

> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +2329,3 @@
> +  gboolean ok;
> +
> +  gst_byte_writer_init_with_size (&bw, gst_buffer_get_size (buffer), FALSE);
> 
> Isn't there an overflow? because you are adding 48 bits to the original
> buffers

That size is not fixed as the third parameter, which means it can allocate more
if needed. But I think you're right in this case, which can be fixed at
initialization for performance.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.