[Bug 778830] v4l2dec: Fix race when going from PAUSED to READY

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778830

--- Comment #9 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 346392:
 --> (https://bugzilla.gnome.org/review?bug=778830&attachment=346392)

::: gst/gstpad.c
@@ +6090,3 @@
+  task = GST_PAD_TASK (pad);
+  if (task == NULL)
+    goto no_task;

I think the goto is not really needed here. Just set ret = GST_TASK_STOPPED,
and then else  ...

::: gst/gstpad.h
@@ +1418,3 @@
 gboolean        gst_pad_pause_task            (GstPad *pad);
 gboolean        gst_pad_stop_task            (GstPad *pad);
+GstTaskState    gst_pad_get_task_state        (GstPad *pad);

Does not seem to align with other declarations.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.