[Bug 779055] basetransform: improve handling of empty peercaps when intersecting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779055

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 CC|                            |slomo at coaxion.net

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to abhimanyu.v from comment #0)
> > This will cause caps to return NULL which will still fail linking. we would
> need to return some caps either it could be peerfilter as in case of
> peerfilter empty or we return template as it is now. I think empty caps is
> kind of similar to NULL caps practically?

Looking at the code of gst_pad_peer_query_caps() again, there's no way how this
can return NULL at all. So the NULL-case is never called currently, and it's
not clear why it exists. The intention behind the NULL-case seems to be "there
is no peer", in which case just the template is taken. "there is no peer (yet)"
is very different from empty caps (aka "no supported common formats) though,
the former is more like any caps.


Is there any specific problem your patch is solving? How can it be reproduced?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.