[Bug 778365] bytereader: offset accounted twice in _masked_scan_uint32_peek for H264 special case

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778365

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.11.2

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
commit 834fd18dfaa79c99cac460f9597b3bb5f7e240d9
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue Feb 21 20:23:51 2017 +0000

    bytereader: fix peek value when scanning for 00 00 01 with non-0 offset

    We would add the offset a second time in _scan_for_start_code()
    when we found a result, but it's already been added to the data
    pointer at the beginning of _masked_scan_uint32_peek(), so the
    peeked value would be wrong if the initial offset was >0, and
    we would potentially read memory out-of-bounds.

    Add unit test for all of this.

    https://bugzilla.gnome.org/show_bug.cgi?id=778365

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.