[Bug 779064] audiobuffersplit: Add drop-last property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779064

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346435|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 346435:
 --> (https://bugzilla.gnome.org/review?bug=779064&attachment=346435)

::: gst/audiobuffersplit/gstaudiobuffersplit.c
@@ +519,3 @@
+        gst_adapter_clear (self->adapter);
+      else
+        gst_audio_buffer_split_output (self, TRUE);

I think it would make sense to call this "strict-buffer-size" or similar, and
also do that on discont. So that never ever a buffer with fewer samples is
output. If that makes sense at EOS, it also is important in the middle on
discont.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.