[Bug 778703] timecodestamper: Timecode from current system time

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778703

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346357|reviewed                    |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 346357:
 --> (https://bugzilla.gnome.org/review?bug=778703&attachment=346357)

Looks good but please split this into 3 patches. These are 3 separate changes,
even your commit message reads like that :)

::: gst/timecode/gsttimecodestamper.c
@@ +304,3 @@
+    timecodestamper->current_tc->minutes = timecodestamper->first_tc->minutes;
+    timecodestamper->current_tc->seconds = timecodestamper->first_tc->seconds;
+    timecodestamper->current_tc->frames = timecodestamper->first_tc->frames;

Should maybe be documented that only these fields are taken (what about field
count btw?) and not flags, framerate, etc.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.