[Bug 777376] matrixmix: New element that mixes audio channels

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777376

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346447|none                        |reviewed
             status|                            |

--- Comment #38 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 346447:
 --> (https://bugzilla.gnome.org/review?bug=777376&attachment=346447)

Generally looks good. Not sure which property should be the one with the
"matrix" name though

::: tests/examples/audiomixmatrix/test-audiomixmatrix.c
@@ +155,3 @@
+  serialized_matrix = gst_value_serialize (&v);
+  gst_printerrln ("Serialized matrix: %s", serialized_matrix);
+  g_free (serialized_matrix);

Here would be nicer probably to show why this property exists...
gst_util_set_object_arg (audiomixmatrix, "matrix", "< < 1, 0> ...");

@@ +203,3 @@
+  g_value_unset (&v2);
+  g_value_take_boxed (&v, a);
+  g_object_set_property (G_OBJECT (audiomixmatrix), "matrix-value-array", &v);

And here, the canonical way of setting properties would be g_object_set(...,
"...", a, NULL);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.