[Bug 777376] matrixmix: New element that mixes audio channels

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777376

--- Comment #40 from Vivia Nikolaidou <vivia at ahiru.eu> ---
(In reply to Sebastian Dröge (slomo) from comment #38)
> Review of attachment 346447 [details] [review]:
> 
> Generally looks good. Not sure which property should be the one with the
> "matrix" name though
> 
> ::: tests/examples/audiomixmatrix/test-audiomixmatrix.c
> @@ +155,3 @@
> +  serialized_matrix = gst_value_serialize (&v);
> +  gst_printerrln ("Serialized matrix: %s", serialized_matrix);
> +  g_free (serialized_matrix);
> 
> Here would be nicer probably to show why this property exists...
> gst_util_set_object_arg (audiomixmatrix, "matrix", "< < 1, 0> ...");

Thanks, added that as a comment :) It's easier to put this as a comment, while
manually creating the GstValueArray is trickier, therefore I kept it there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.