[Bug 779067] glupload: Add support for Vivante DirectTexture uploads

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779067

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Matthew Waters (ystreet00) from comment #9)

> > > @@ +1395,3 @@
> > > +      gl_format, (void **) &unmap_data->map.data,
> > > +      &((GstPhysMemory *) in_mem)->phys_addr);
> > > +  glTexDirectInvalidateVIV (GL_TEXTURE_2D);
> > > 
> > > These should use the functions in GstGLFuncs in order to use the correct GL
> > > functions for the correct context/thread.
> > > 
> > > Which results in, even if GST_GL_HAVE_VIV_DIRECTVIV is true (which I don't
> > > think we need at all), glTexDirectVIVMap and glTexDirectInvalidateVIV may
> > > not exist at runtime and should be a condition for choosing to upload with
> > > this uploader.
> > 
> > So would you suggest to a) check at configure if the symbol is there to
> > decide whether to compile in that codepath or not, and b) load the symbol
> > dynamically when the uploader is created?
> 
> Yes, exactly.

Ok, will do, thanks for the review :) And the header mess is not really
relevant anymore then as I don't need the declaration from the header but can
just declare the function types locally then as function pointers.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.