[Bug 770934] rtsp: Make RTSP TIMEOUT in RTP/RTSP/TCP transport deterministic

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770934

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344846|none                        |needs-work
             status|                            |

--- Comment #24 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 344846
  --> https://bugzilla.gnome.org/attachment.cgi?id=344846
New solution plugins base

>--- a/gst-libs/gst/rtsp/gstrtspconnection.h
>+++ b/gst-libs/gst/rtsp/gstrtspconnection.h
>@@ -192,6 +195,10 @@ typedef struct {
>                                              GstRTSPMessage *request,
>                                              GstRTSPMessage *response,
>                                              gpointer user_data);
>+  void              (*connloss_status)  (GstRTSPWatch *watch,
>+                                         GstRTSPResult result,
>+                                         GSocket *write_socket,
>+                                         gpointer user_data);
> 
>   /*< private >*/
>   gpointer _gst_reserved[GST_PADDING-1];

No opinion on the new vfunc or the rest of the patch yet, but you need to
change the padding here to GST_PADDING-2, that's what it's for :)

>diff --git a/tests/check/libs/struct_arm.h b/tests/check/libs/struct_arm.h
>index d46b37b..b7b3e6e 100644
>--- a/tests/check/libs/struct_arm.h
>+++ b/tests/check/libs/struct_arm.h
>@@ -56,7 +56,7 @@ GstCheckABIStruct list[] = {
>   {"GstRTSPTimeRange", sizeof (GstRTSPTimeRange), 40},
>   {"GstRTSPTransport", sizeof (GstRTSPTransport), 76},
>   {"GstRTSPUrl", sizeof (GstRTSPUrl), 32},
>-  {"GstRTSPWatchFuncs", sizeof (GstRTSPWatchFuncs), 40},
>+  {"GstRTSPWatchFuncs", sizeof (GstRTSPWatchFuncs), 44},

And then you also don't need to fix up these structure sizes, which are
supposed to stay constant to maintain ABI stability.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.