[Bug 779131] waylandsink: disable last sample sink feature

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779131

--- Comment #2 from Fabien Dessenne <fabien.dessenne at st.com> ---
Oh yes it probably prevents screenshot.

The point is that waylandsink does not really have the full control of the
buffer locking since this is delegated to the wayland compositor. From what I
have observed weston keeps a reference on a buffer even after that one is no
more displayed (released more or less one frame later). So the pool is always
close to propose 'unavailable' buffers.
In some cases, I observed dead lock :  all buffers used by weston or decoder
and no one wants to free any.
The other point is that when DMABuf buffers are used, waylandsink does not
propose any pool but it is up to the upstream element to propose one. But this
upstream element is not aware of sink/weston buffer locking, so it is hard to
set correctly the min_buffer value.
Disabling last-sample solves a part of the problem

But I agree with you: this has a drawback (that I shall have explicitly
mentioned in the initial comment).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.