[Bug 779131] waylandsink: disable last sample sink feature

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779131

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
You can re-purpose this one really. What you came up with, is a solution to
your problem. I'm just saying, this isn't a solution. last-sample should not
stall your pipeline, and that's what you should fix. enable-last-sample is ON
on every single video-sink by default. It would be very inconsistent to not
follow this. Obviously, if you don't use screenshot in your application, turn
it off. Now, 2 should be enough, but slow, since it means a buffer cannot be
filled while being rendered. So 3 is a much better default. Exception, if you
add support for interlacing at some point, you may need to increase this a bit.
So the buffer purpose would be:

1. Upstream being filled
2. Being rendered by the compositor
3. Stuck in last-sample

Arguably, this extra one could have been proposed by upstream, but I think in
practice no one does that, so better account at least 1 buffer being out. In
many many cases, you will not notice, as most buffer pools can grow on demand.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.