[Bug 779175] registry: Only scan plugin files that end with an extension

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Feb 24 14:49:39 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779175

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346636|none                        |needs-work
             status|                            |

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 346636
  --> https://bugzilla.gnome.org/attachment.cgi?id=346636
registry: Only scan plugin files that end with an extension

>-    if (!g_str_has_suffix (dirent, G_MODULE_SUFFIX)
>+    if (!g_str_has_suffix (dirent, "." G_MODULE_SUFFIX)
> #ifdef GST_EXTRA_MODULE_SUFFIX
>-        && !g_str_has_suffix (dirent, GST_EXTRA_MODULE_SUFFIX)
>+        && !g_str_has_suffix (dirent, "." GST_EXTRA_MODULE_SUFFIX)
> #endif

I just checked and it seems GST_EXTRA_MODULE_SUFFIX already contains a ".", so
we just need to do this for G_MODULE_SUFFIX (I think it's kinda right that the
define contains the dot, so I'd rather keep it inconsistent here in the code
than fix up the GST_EXTRA_MODULE_SUFFIX define - what do you think?)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list