[Bug 779202] ref counting issue fix for Context in gst-libs/gst/gl/gstglcontext.c

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779202

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346683|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 346683:
 --> (https://bugzilla.gnome.org/review?bug=779202&attachment=346683)

Explain the commit message, I mean :)

::: gst-libs/gst/gl/gstglcontext.c
@@ +694,2 @@
     _context_share_group_unref (context->priv->sharegroup);
+    context->priv->sharegroup = null;

Upper-case NULL

@@ +698,3 @@
+  if (context->display) {
+    gst_object_unref (context->display);
+    context->display = null;

And here

@@ +749,2 @@
   if (result && activate) {
+    GThread *saveOldThread = context->priv->active_thread;

save_old_thread, also below

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.