[Bug 778397] Iosassetsrc lacks orientation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778397

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346742|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 346742:
 --> (https://bugzilla.gnome.org/review?bug=778397&attachment=346742)

How does this relate to the other patch? The other one seems to be obsolete by
this one?

::: sys/applemedia/iosassetsrc.m
@@ +310,3 @@
   }

+  if (offset == 0) {

offset == 0 might not be enough, better add a boolean to remember if you
already did this (and reset that boolean when restarting). In pull mode or if
there was a seek at the very beginning, offset will never be 0.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.