[Bug 779333] New: tsdemux: Probably broken code, compiler warning with gcc 7

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=779333

            Bug ID: 779333
           Summary: tsdemux: Probably broken code, compiler warning with
                    gcc 7
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: slomo at coaxion.net
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: bilboed at bilboed.com, thaytan at noraisin.net
     GNOME version: ---

pesparse.c: In function ‘mpegts_parse_pes_header’:
pesparse.c:324:46: error: ‘<<’ in boolean context, did you mean ‘<’ ?
[-Werror=int-in-bool-context]
         (GST_READ_UINT16_BE (data) & 0x1fff) << (val8 & 0x20) ? 10 : 7;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

I'm not sure what this code is trying to do, but it seems to make no sense in
any way. It would either shift by 0 or by 0x20 there. If it shifts by 0x20, it
will be 0 and evaluate to 7... otherwise it will be 7 if those 2 bytes are 0,
or 10 otherwise.

This does not seem to make any sense and I can't find the spec currently :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.