[Bug 722560] rtprtxreceive: cleanup orphan retransmission requests
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Feb 28 11:16:12 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=722560
--- Comment #5 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
Looking at this again after a long time, I'm having a hard time to understand
what the values of delay, frequency and period actually mean. The unit test
attached here looks like it gets them wrong, compared to a real test with
rtpjitterbuffer.
In any case, rtprtxreceive seems to have some sort of request timeout
functionality now, only that it is only triggered when a duplicate request (for
the same seqnum, with different ssrc) arrives, so it does not really fix the
"leak". But this leak, if it ever happens, it's going to be so small that it
does not really matter I think...
I'm attaching a small patch below that would fix the leak, anyways. The idea is
to run the check in _chain() instead of only when receiving a duplicate
request.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list