[Bug 771650] Adding additional tags to FLV header

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771650

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338573|none                        |reviewed
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 338573:
 --> (https://bugzilla.gnome.org/review?bug=771650&attachment=338573)

Looks good now. My only concern, and I'd like some feedfback before merging,
this make the muxer/demuxer asymmetric. We should probably also add the bits in
the demuxer to parse these. At the same occasion, the magic numbers added to be
put in a common header (there is already a lot of magic numbers in this code,
it's not great to add more).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.