[Bug 775204] validate: transcode failure with vaapi: gst buffer arrives before caps event in queue.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jan 4 10:03:35 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=775204

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342813|none                        |needs-work
             status|                            |

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 342813:
 --> (https://bugzilla.gnome.org/review?bug=775204&attachment=342813)

Thanks!  Good catch!

Just a silly code style thing.

::: gst/vaapi/gstvaapipostproc.c
@@ +1314,3 @@
+  if (!src_caps_changed)
+    /* set passthrough according to caps changes or filter changes */
+    gst_vaapipostproc_set_passthrough (trans);

please wrap the if with braces or move the comment above the if

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list