[Bug 776900] decklinkvideosrc: Do not append a zero timecode if none is found on the source

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776900

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342954|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342954:
 --> (https://bugzilla.gnome.org/review?bug=776900&attachment=342954)

::: sys/decklink/gstdecklink.cpp
@@ +853,1 @@
           }

This code here seems to leak the IDeckLinkTimecode. You need to call
::Release() on it, like on the frames/packets (done inside got_video_frame /
got_audio_packet at some point).

::: sys/decklink/gstdecklink.h
@@ +211,2 @@
   /* Set by the video source */
+  void (*got_video_frame) (GstElement *videosrc, IDeckLinkVideoInputFrame *
frame, GstDecklinkModeEnum mode, GstClockTime capture_time, GstClockTime
stream_time, GstClockTime stream_duration, guint hours, guint minutes, guint
seconds, guint frames, BMDTimecodeFlags bflags, gboolean no_signal, gboolean
have_timecode);

Generally all looks good, but it would seem better to reduce the amount of
parameters here a lot by just passing the IDeckLinkTimeCode * here. It being
NULL would mean no timecode then and the consumer can make use of that

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.