[Bug 776927] [PATCH] Accept GLMemory buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

--- Comment #4 from Matt Fischer <mattfischer84 at gmail.com> ---
(In reply to Hyunjun Ko from comment #1)
> (In reply to Matt Fischer from comment #0)
> Supported format might be different depends on chipset. That's why we need
> to find out what formats are supported on the current chipset.
> But in this case, I don't know how to handle this case.
That makes sense.  It's just interesting that even in a case where the chipset
reports only handling YUV formats, I can pass in a surface that was created
with RGB32, and it will be encoded properly.  Maybe this is behavior that
happens to work in my driver, but wouldn't in other drivers?  I don't have any
experience with this area, so I'm not sure how to proceed.

> I beleive it can be done, but IMHO, it's not necessary.
In that case, what I have should work, and leaves the door open for some other
motivated developer to add the missing piece in the future. :)

> As I said in the mailing list, if your plugin pass gl context via context
> query, it should be fine. Because vaapi plugin will create proper display if
> it got it via gst_vaapi_plugin_base_find_gl_context.
Ah sorry, my confusion was that I was working off of an older version, where
this gst_vaapi_plugin_base_find_gl_context() function hadn't been implemented
yet.  On master it looks like it should work correctly without any changes. 
I'll upload a new version of my patch which removes the changes I added there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.