[Bug 775203] validate: transcode failure with vaapi: vaapi-bufferpool is dropped in videorate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775203

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340960|none                        |needs-work
             status|                            |

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 340960:
 --> (https://bugzilla.gnome.org/review?bug=775203&attachment=340960)

::: gst/vaapi/gstvaapipluginbase.c
@@ +793,1 @@
     gst_query_add_allocation_param (query, plugin->sinkpad_allocator, NULL);

Interesting. It seems that videorate, if an allocator is proposed, it tries to
use it, regardless the buffer pool. And our vaapi allocator cannot be used
outside of the vaapi video buffer poll. And, if an allocator is proposed, it
needs at least one spare buffer.

I propose two things:

1\ instead of one buffer as minimum, set 2, which is more safe
2\ if you change this, you have to instantiate 2 buffers when configuring the
buffer pool. You have to change that in ensure_sinkpad_buffer_pool()

And please test this change intensively with vaapisink.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.