[Bug 774254] vaapi: deadlock during seek of certain media in gst-validate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774254

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342474|none                        |needs-work
             status|                            |

--- Comment #13 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 342474:
 --> (https://bugzilla.gnome.org/review?bug=774254&attachment=342474)

:D great!

::: gst-libs/gst/vaapi/gstvaapidecoder_h264.c
@@ +3269,3 @@
   base_picture->type = GST_VAAPI_PICTURE_TYPE_NONE;
   base_picture->view_id = pi->view_id;
   base_picture->voc = pi->voc;

since type, view_id and voc are also set in gst_vaapi_picture_create() when a
picture clone is created, I wonder is should also put those assignation inside
of the if. Also use G_LIKELY for optimization, since it is going to be the
common case (not having a parent_picture)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.