[Bug 776928] hlsdemux: Set fragment header uri if exists

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776928

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342995|none                        |needs-work
             status|                            |

--- Comment #4 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 342995:
 --> (https://bugzilla.gnome.org/review?bug=776928&attachment=342995)

::: ext/hls/m3u8.c
@@ +562,3 @@
+            gst_m3u8_media_file_unref (self->init_media);
+
+          self->init_media = file;

Don't you need to set the offset and size?

::: ext/hls/m3u8.h
@@ +66,3 @@
   GList *files;

+  GstM3U8MediaFile *init_media; /* Media Initialization written in EXT-X-MAP
*/

HLS spec allows multiple initialization segments to happen.

"It applies to every Media Segment that appears after it in the Playlist until
the next EXT-X-MAP tag or until the end of the playlist."

It should be designed to allow that. Maybe GstM3U8MediaFile needs a pointer to
itself to store its initialization segment if available. Another option is to
interleave it in the media files as it were a regular file.

I'd prefer the first one to have it logically distinguished in the code. Or, if
we do the second, add a boolean to indicate if it is a header.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.