[Bug 777009] urisourcebin: Never push actual EOS event to slot

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 9 10:58:25 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777009

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343130|0                           |1
        is obsolete|                            |

--- Comment #9 from Jan Schmidt <thaytan at noraisin.net> ---
Created attachment 343142
  --> https://bugzilla.gnome.org/attachment.cgi?id=343142&action=edit
urisourcebin: Never push actual EOS event to slot

Due to the special nature of adaptivedemux, reconfigure happens
frequently with seek/track-change.
In very exceptional cases, the following sequence is possible:
  * EOS event is pushed to queue element and still buffers are queued
  * During draining remaining buffers, a reconfigure event arrives from
downstream
  * Because the sinkpad is EOS, the reconfigure event fails and triggers
    a flow return from downstream that is not GST_FLOW_OK.

Because non FLOW_OK return will cause element error in queue element,
avoid the sinkpad getting marked EOS by using a custom event in place of
EOS.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list