[Bug 776927] vaapi: plugins: accept GLMemory buffers from upstream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776927

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343036|none                        |reviewed
             status|                            |

--- Comment #6 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 343036:
 --> (https://bugzilla.gnome.org/review?bug=776927&attachment=343036)

Hi,

Thanks for this contribution!

The idea looks good, but I my idea is to get rid of the custom GL API in
gstreamer-vaapi and use GstGL instead. Then, many of this code will be removed
and we should think in another way to keep this functionality.

If I understand correctly, only the we could import EGL textures to VASurfaces.
Again, IIUC, this is only possible if the EGL textures are EGL Images and they
can export its internal dmabuf descriptor. Bearing this in mind, I think that
the code would be improved and simplified if the "uploader" function, just
check if the incoming GstMemory is EGL and has an exportable dmabuf. If so,
grab the dmabuf descriptor and "acquire" it to import it as a VASurface.

But this gets trickier, since we would only negotiate GstGLMemory if upstream
provides EGL based buffers with exportable dmabufs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.