[Bug 777009] urisourcebin: Never push actual EOS event to slot

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 9 11:54:49 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777009

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.11.1

--- Comment #20 from Jan Schmidt <thaytan at noraisin.net> ---
Thanks for the re(In reply to Seungha Yang from comment #19)
> (In reply to Jan Schmidt from comment #18)
> > OK, I updated the description. Does that match what's happening Seungha?
> 
> It's perfect!! :)

Great, thanks! Pushed as:

commit 87f21a925c5e404add906e7ddd134b52d4367698
Author: Seungha Yang <sh.yang at lge.com>
Date:   Sun Jan 8 21:53:27 2017 +0900

    urisourcebin: Clear EOS state with stream-start/flush-stop event

    The EOS state marker should cleared on stream-start or flush-stop

    https://bugzilla.gnome.org/show_bug.cgi?id=777009

commit c10e7c5011e5149712bf3c7c9d9bb8ee765c4ac6
Author: Seungha Yang <sh.yang at lge.com>
Date:   Sun Jan 8 21:36:04 2017 +0900

    urisourcebin: Never push actual EOS event to slot

    Due to the special nature of adaptivedemux, reconfigure happens
    frequently with seek/track-change.
    In very exceptional cases, the following sequence is possible:
      * EOS event is pushed to queue element and still buffers are queued
      * During draining remaining buffers, reconfiguration downstream
    happens due to track switch.
      * The queue gets a not-linked flow return from downstream
      * Because the sinkpad is EOS, the queue registers an
        error on the bus, causing the pipeline to fail.

    Avoid the sinkpad getting marked EOS in the first place, by using a
    custom event in place of EOS.

    https://bugzilla.gnome.org/show_bug.cgi?id=777009

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list