[Bug 776490] gstplayer: Add video/audio/text sink property for gstplayer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776490

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342488|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 342488:
 --> (https://bugzilla.gnome.org/review?bug=776490&attachment=342488)

This looks generally like the right approach

::: gst-libs/gst/player/gstplayer-video-overlay-video-renderer.c
@@ +86,3 @@
       break;
+    case VIDEO_OVERLAY_VIDEO_RENDERER_PROP_VIDEO_SINK:
+      self->video_sink = g_value_get_object (value);

_dup_object() and unref() in finalize()

@@ +204,3 @@
 GstPlayerVideoRenderer *
+gst_player_video_overlay_video_renderer_new (gpointer window_handle,
+    GstElement * video_sink)

Add documentation too

::: gst-libs/gst/player/gstplayer-video-overlay-video-renderer.h
@@ +42,2 @@
 GType gst_player_video_overlay_video_renderer_get_type (void);
+GstPlayerVideoRenderer * gst_player_video_overlay_video_renderer_new (gpointer
window_handle, GstElement * video_sink);

Don't change the API please, better add a new "_new_with_sink()" function here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.