[Bug 776458] urisourcebin: Always configure typefind

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776458

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #342447|none                        |reviewed
             status|                            |

--- Comment #10 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 342447:
 --> (https://bugzilla.gnome.org/review?bug=776458&attachment=342447)

::: gst/playback/gsturisourcebin.c
@@ +2114,3 @@
       GST_DEBUG_PAD_NAME (pad), GST_ELEMENT_NAME (element));
+
+  /* FIXME: What should we do if fail to setup typefind here ? */

There's no need to do extra - if setup_typefind fails, it will already have
posted an error on the bus.

@@ +2115,3 @@
+
+  /* FIXME: What should we do if fail to setup typefind here ? */
+  setup_typefind (urisrc, pad);

I think this code should be:

caps = gst_pad_get_current_caps (pad);
if (caps == NULL)
  setup_typefind (urisrc, pad);
else {
  handle_new_pad (urisrc, pad, caps);
  gst_caps_unref (caps);
}

That way, if the pad does already have caps, we can skip the typefind element
entirely (which will just get the same caps and then fire the have-type signal
anyway)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.