[Bug 758257] adaptivedemux: don't expose pads until caps are known

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jan 10 05:36:26 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=758257

--- Comment #18 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Jan Schmidt from comment #17)
> Review of attachment 343079 [details] [review]:

> I suspect the only part we actually need is the part that moves clearing the
> do_block flag after removing old pads?
Not only clearing "do_block" parts, calling _expose_streams() in main thread
seems to be needed.

Frankly speaking, I'm not sure why your original patch does not work on master
version. Maybe, I suspect that calling _expose_streams() in downloading thread
might causes some issues and always calling it in downloading thread seems not
to be unsafe. I'm keep debugging now, though.

Main concept of my first patch is, calling _start_task() and _expose_streams()
on main thread, and then, waiting until "preroll complete" (notifyed by
download thread)

What is your opinion? Any way, I'll split my patch into several parts for easy
review.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list