[Bug 776490] gstplayer: Add video/audio/text sink property for gstplayer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776490

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343211|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343211:
 --> (https://bugzilla.gnome.org/review?bug=776490&attachment=343211)

::: gst-libs/gst/player/gstplayer-video-overlay-video-renderer.c
@@ +229,3 @@
+
+  return g_object_new (GST_TYPE_PLAYER_VIDEO_OVERLAY_VIDEO_RENDERER,
+      "window-handle", window_handle, "video-sink", video_sink, NULL);

You pass a string to a GstElement* property, that doesn't work

::: gst-libs/gst/player/gstplayer-video-overlay-video-renderer.h
@@ +42,3 @@
 GType gst_player_video_overlay_video_renderer_get_type (void);
 GstPlayerVideoRenderer * gst_player_video_overlay_video_renderer_new (gpointer
window_handle);
+GstPlayerVideoRenderer * gst_player_video_overlay_video_renderer_new_with_sink
(gpointer window_handle, const gchar * video_sink_name);

A GstElement* here would be better. You might want to pass something that does
not have a GstElementFactory, like some custom bin with various other elements

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.