[Bug 777009] urisourcebin: Never push actual EOS event to slot
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jan 11 11:41:50 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=777009
--- Comment #22 from Jan Schmidt <thaytan at noraisin.net> ---
(In reply to Arun Raghavan from comment #21)
> Review of attachment 343145 [details] [review]:
>
> ::: gst/playback/gsturisourcebin.c
> @@ +1256,3 @@
> slot = g_object_get_data (G_OBJECT (pad), "urisourcebin.slotinfo");
> +
> + gst_pad_push_event (slot->srcpad, gst_event_new_eos ());
>
> The code after this checks for whether slot is NULL or not, so either this
> should have the corresponding check, or if it can never be NULL, that check
> can be removed.
Yes, I get coverity reports too ;)
Have patch locally - pushing soon.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list