[Bug 776983] opusenc does not discard silence if DTX enabled

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776983

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343113|none                        |needs-work
             status|                            |

--- Comment #5 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 343113:
 --> (https://bugzilla.gnome.org/review?bug=776983&attachment=343113)

You should push a GAP event instead of a buffer. It seems that the base class
has nothing to help, so something like ret = gst_pad_push (encoder->srcpad,
timestamp, duration); should be enough if the finish frame didnt return an
error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.