[Bug 777100] qtmux: Write tapt atom for MOV files if PAR not 1/1

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777100

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343359|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343359:
 --> (https://bugzilla.gnome.org/review?bug=777100&attachment=343359)

Generally looks good, just two minor things

::: gst/isomp4/gstqtmux.c
@@ +4418,2 @@
+  if (qtmux_klass->format == GST_QT_MUX_FORMAT_QT &&
+      width > 640 && width <= 1052 && height >= 480 && height <= 576) {

Why only for <HD resolutions? Shouldn't at least clap also be written for HD?

@@ +4445,3 @@
+          height * par_den);
+      dar_num = width * par_num / cdiv;
+      dar_den = height * par_den / cdiv;

You calculate width*par_num (and the other one) twice here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.