[Bug 736752] mp4mux/qtmux: Add HEVC support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=736752

--- Comment #4 from Aurélien Zanelli <aurelien.zanelli at parrot.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 343375 [details] [review]:
> 
> Some things that are weird, but they're probably copy&paste from the h264
> code. Maybe omit them here and provide another patch for h264 :)
> 
> ::: gst/isomp4/gstqtmux.c
> @@ +4240,3 @@
> +
> +    if ((strcmp (format, "hvc1") != 0 && strcmp (format, "hev1") != 0) ||
> +        alignment == NULL || strcmp (alignment, "au") != 0) {
> 
> alignment can't possibly be NULL here (and stream-format can't be missing
> either). They're both in the template caps.

Indeed, I will remove all this tests as all are already done when intersecting
with pad template.

> 
> @@ +4261,3 @@
> +      gint avg_bitrate = 0;
> +
> +      gst_structure_get_int (structure, "bitrate", &avg_bitrate);
> 
> This should come via tags if anything, the caps generally don't have the
> bitrate

Copy&paste from h264, I assumed that weird code use it, but it doesn't make
sense and associated qtmux fields are set on tags event. I will provide a patch
for h264.

and thanks for review.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.