[Bug 773709] player: Add get video thumbnail API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773709

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343400|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343400:
 --> (https://bugzilla.gnome.org/review?bug=773709&attachment=343400)

::: gst-libs/gst/player/gstplayer.c
@@ +4265,3 @@
+ * @player: #GstPlayer instance
+ * @format: output format of the video snapshot
+ * @config: (allow-none) Additional configuration

(allow-none) should be followed by a colon (:). Also actually nowadays this
should be (nullable) instead

@@ +4272,3 @@
+ * - width, height of type G_TYPE_INT
+ * - pixel-aspect-ratio of type GST_TYPE_FRACTION
+ *   If no config is set, pixel-aspect-ratio would be 1/1 excpet RAW_NATIVE
format

Typo: excpet. Also write the whole enum value instead of just RAW_NATIVE

@@ +4334,3 @@
+  }
+
+  if (format != GST_PLAYER_THUMBNAIL_RAW_NATIVE) {

If given in the config, I would also override it for RAW_NATIVE. Just if it's
*not* given the default should be used for RAW_NATIVE instead of 1/1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.