[Bug 766177] qtdemux: Critical errors reported playing mp4 file with only xmp tags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766177

David Warman <dwarman at manglebit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dwarman at manglebit.org

--- Comment #12 from David Warman <dwarman at manglebit.org> ---

Thiago's patch is a much appreciated simplification of the taglist handling,
but I have found one problem that it does not yet solve.

This is that gst_demux_push_tags() takes a second reference while pushing the
new tag event to send global tags (qtdemux.c:958), so tag_list becomes
non-writable.  A subsequent call to qtdemux_handle_xmp_taglist() then fails
with
"gst_tag_list_insert: assertion 'gst_tag_list_is_writable (into)' failed"

It seems inefficient to make qtdemux->tag_list writable immediately after the
2nd reference is taken (although perhaps easier to think about), so I have
settled for doing so in qtdemux_parse_uuid(), just before the call to
qtdemux_handle_xmp_taglist().  This fixes my immediate problem, but am I still
wondering if it would be better to keep qtdemux->tag_list always writable?

I'll attach a qtdemux debug trace for the failing condition and a further patch
file.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.