[Bug 773091] check: Add API to filter g_warning/g_critical etc

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773091

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343427|none                        |reviewed
             status|                            |

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 343427
  --> https://bugzilla.gnome.org/attachment.cgi?id=343427
Updated patch to address issues in the feedback.

Thanks for the updated patch, looks mostly fine to me, just a few smaller
things:

>+	gst_check_log_filter_add \
>+	gst_check_log_filter_remove \
>+	gst_check_log_filter_clear \

I think I'd prefer

 gst_check_add_log_filter()

etc. (even if both patterns exist in GStreamer). Maybe it should even be _new()
with a separate _add() step? Not sure if that would be nicer for bindings or
not.

- Please add 'Since: 1.12' markers to all the gtk-doc chunks at the bottom

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.