[Bug 777146] vaapisink: segfault caused by race condition with OverlayInterface expose method

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777146

--- Comment #10 from Matt Staples <staples255 at gmail.com> ---
Review of attachment 343453:
 --> (https://bugzilla.gnome.org/review?bug=777146&attachment=343453)

::: gst/vaapi/gstvaapisink.c
@@ +1461,2 @@
   gst_vaapi_display_unlock (GST_VAAPI_PLUGIN_BASE_DISPLAY (sink));
+  gst_buffer_replace (&old_buf, NULL);

I think this changes the behavior.  Previously, sink->video_buffer was set to
NULL at the end of this function, but now it's being set to a new reference to
buffer.  Was that intentional?
If not, I think sink->video_buffer could just be assigned NULL on line 1458.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.