[Bug 777206] mosaic issue for MPEG DASH live streaming

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777206

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343465|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343465:
 --> (https://bugzilla.gnome.org/review?bug=777206&attachment=343465)

::: ext/dash/gstdashdemux.c
@@ +1155,3 @@
+    if (gst_mpd_client_is_live(dashdemux->client)) {
+      if (!GST_ADAPTIVE_DEMUX_STREAM_NEED_HEADER (stream)) {
+        if (dashstream->active_stream &&
dashstream->active_stream->cur_representation) {

While this probably works... don't we explictly switch the representation
somewhere in this code and could just set a boolean for that which is checked
here and then reset again after handling it?

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.h
@@ +187,3 @@
   gboolean eos;
+
+  gchar *last_representation_id;

It seems like this should be in the DASH subclass instead. Representation is
something DASH specific

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.