[Bug 777206] mosaic issue for MPEG DASH live streaming

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=777206

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343518|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 343518:
 --> (https://bugzilla.gnome.org/review?bug=777206&attachment=343518)

::: ext/dash/gstdashdemux.c
@@ +1154,3 @@
   if (gst_mpd_client_get_next_fragment_timestamp (dashdemux->client,
           dashstream->index, &ts)) {
+    if (gst_mpd_client_is_live(dashdemux->client)) {

Why only for live streams? Should be the same for VOD streams

@@ +1160,3 @@
+          if (!g_strcmp0 (dashstream->active_stream->cur_representation->id,
dashstream->last_representation_id)) {
+            stream->need_header = TRUE;
+            GstCaps *caps;

Put the variable declarations before any code.

@@ +1164,3 @@
+                dashstream->active_stream->cur_representation->bandwidth);
+            caps = gst_dash_demux_get_input_caps (dashdemux,
dashstream->active_stream);
+            gst_adaptive_demux_stream_set_caps (stream, caps);

You're probably leaking the caps here

@@ +1169,3 @@
+      }
+      if (dashstream->last_representation_id)
+         g_free (dashstream->last_representation_id);

g_free() is NULL-safe, see below

@@ +2752,3 @@

+  if (dash_stream->last_representation_id) {
+    g_free (dash_stream->last_representation_id);

g_free() is NULL-safe, you don't need to check for NULL first

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.